Thanks for using the TrueNAS Community Edition issue tracker! TrueNAS Enterprise users receive direct support for their reports from our support portal.

services: SMB: auxiliary parameters: allow empty lines and comments

Description

you can't add empty lines and comments any more to SMB: auxiliary parameters. This seems bad because the admin might want to structure, comment old values or add comments. i dont see the problem to skip/filter them even if you want to pass them on.

see also https://ixsystems.atlassian.net/browse/NAS-106953#icft=NAS-106953

Problem/Justification

None

Impact

None

SmartDraw Connector

Katalon Manual Tests (BETA)

Activity

Show:

Andrew Walker October 29, 2020 at 1:51 PM

Okay. Issue only affects 11.3-U5.

We have regular problems with users inputting invalid auxiliary parameters, breaking the SMB service, and filing bug tickets. It's unclear whether there will be an 11.3-U6, but I backported validation from 12.0-stable. Enclosing parameters in quotes will not be supported. Validation will remain bare-bones, we just pass along parameters to pyparam (lib/param in samba).

Auxiliary parameters in general are a grey-area in terms of what's supported. We generally won't do something that will impact them in a U-release, but behavior and what's permitted may change radically in major version changes. Bug reports and issues with auxiliary parameters will also generally receive a low priority.

The big picture of our path forward is to reduce user's reliance on them to do things. This will be in part achieved by adding configuration presets to SMB shares. If you have a particular item that must work in your environment, then I recommend that you file a feature request to expose it.

Bug Clerk October 29, 2020 at 1:37 PM

Andrew Walker October 29, 2020 at 12:03 PM

Please attach a debug from the affected system and fill out the version information in this form.

Metis IT October 29, 2020 at 9:53 AM

i noticed this behaviour on FreeNAS-11.3-U5. 

After your comment i tested on TrueNAS-12.1-MASTER-20201... and the issue seems gone.

But i noticed that entered parameters are not vaildated against smb.conf syntax. so you can add something like "asd =sdgkb" and no error comes up.

Andrew Walker October 29, 2020 at 9:26 AM

Empty lines and comments are permitted in the DB (and show in the GUI), but they are not added to the actual service configuration due to limitations of the configuration backend we are using for samba.

Complete

Details

Assignee

Reporter

Impact

Low

Fix versions

Priority

More fields

Katalon Platform

Created October 28, 2020 at 11:09 PM
Updated July 1, 2022 at 5:00 PM
Resolved October 29, 2020 at 1:37 PM

Flag notifications