'>' not supported between instances of 'str' and 'Version'

Description

truenas# midclt call -job chart.release.create '{"catalog": "OFFICIAL", "train": "test", "item": "ix-chart", "values": {"image": {"repository": "adguard/adguardhome"}, "portForwar
dingList": [{"containerPort": "3000", "nodePort": "9330"}], "volumes": [ {"datasetName": "config", "mountPath": "/opt/adguardhome/work"}, {"datasetName": "config", "mountPath": "/o
pt/adguardhome/conf"}], "workloadType": "Deployment"}, "version": "2010.0.2", "release_name": "adguardhome"}'
Status: (none)
Total Progress: [________________________________________] 0.00%
'>' not supported between instances of 'str' and 'Version'
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/middlewared/job.py", line 372, in run
await self.future
File "/usr/lib/python3/dist-packages/middlewared/job.py", line 408, in __run_body
rv = await self.method(*([self] + args))
File "/usr/lib/python3/dist-packages/middlewared/schema.py", line 1022, in nf
return await f(*args, **kwargs)
File "/usr/lib/python3/dist-packages/middlewared/plugins/chart_releases_linux/chart_release.py", line 196, in do_create
if await self.query([['id', '=', data['release_name']]]):
File "/usr/lib/python3/dist-packages/middlewared/schema.py", line 1022, in nf
return await f(*args, **kwargs)
File "/usr/lib/python3/dist-packages/middlewared/plugins/chart_releases_linux/chart_release.py", line 134, in query
release_data['update_available'] = latest_version > current_version
TypeError: '>' not supported between instances of 'str' and 'Version'

Problem/Justification

None

Impact

None

SmartDraw Connector

Katalon Manual Tests (BETA)

Activity

Show:

Hao December 3, 2020 at 3:10 AM

@Waqar Ahmed It works fine now. Thank you.

Waqar Ahmed December 2, 2020 at 4:50 PM

@Hao this should address the defaults as well ( https://github.com/truenas/charts/pull/8/files ) so that we don't override the CMD in dockerfile by default. Thank you for pointing it out.

Waqar Ahmed December 2, 2020 at 3:00 PM

@Hao that is because we have a default CMD specified `sleep infinity` to let the container running. Can you please update the chart release ?

midclt call -job chart.release.update 'adguardhome' '{"values": {"containerCommand": [], "containerArgs": []}}'

We have default values specified for these which override the default specified in the dockerfile. However i am thinking we should not to do that as that's just a cause of confusion. Please let me know if it works otherwise.

Hao December 2, 2020 at 8:19 AM

dockerfile : adguard/adguardhome Dockerfile - Docker Hub

Hao December 2, 2020 at 8:18 AM

The program in the container is not running.

truenas# docker ps|grep adg
6897a7a1fa33        216d9a64fc5f        "sleep infinity"         12 minutes ago      Up 12 minutes                           k8s_ix-chart_adguardhome-ix-chart-f6c9d7d49-km4pr_ix-adguardhome_9d1ab2bb-4ae6-4be4-915c-531f7a2137f4_1
cffea1c3c105        rancher/pause:3.1   "/pause"                 13 minutes ago      Up 12 minutes                           k8s_POD_adguardhome-ix-chart-f6c9d7d49-km4pr_ix-adguardhome_9d1ab2bb-4ae6-4be4-915c-531f7a2137f4_1
truenas# docker exec -it 6897a7a1fa33 /bin/sh
/opt/adguardhome/work # ps -ef
PID   USER     TIME  COMMAND
    1 root      0:00 sleep infinity
   12 root      0:00 /bin/sh
   17 root      0:00 ps -ef
/opt/adguardhome/work #

Complete

Pinned fields

Click on the next to a field label to start pinning.

Details

Assignee

Waqar Ahmed

Reporter

Hao

Priority

Low

More fields

Katalon Platform

Created December 1, 2020 at 5:14 AM

Updated July 1, 2022 at 3:50 PM

Resolved December 1, 2020 at 9:15 AM

Configure