I took the subject of the ticket at face value and didn't look at the actual code until now. It seems the isn't as much suppressing the alerts as clarifying what to do with them and removing cores at upgrade.

Fair solution to the problem.

Kudos for actually clarifying the alert message to be useful rather than just removing it.

If you look carefully at the code that has been committed related to the issue (umbrella one involving core files), you will notice that there are two general things that we have done for the next release related to the corefiles.
1) old cores are removed on upgrade (because they do not apply to the current version and user has chosen not to submit them)
2) help text regarding what to do with core files generated by the alert has been improved to make it somewhat more actionable by the end-user.

(1) and (2) combined are to improve the signal-to-noise ratio in the bug-tracker and help us fix the underlying issues.

The reason why we added the alert to begin with was to help catch issues that we have not been able to catch in our lab / regression tests and use the info to improve the product for our end-users.

Just ignore the cores, it will be fine Jim!

Here's a crazy thought, what about fixing the things causing the core files? Just ignoring them will cause them to build up in the system until you run the system out of space.

You could just choose to delete them to prevent the disk space issue, but then you loose the chance to fix things that are crashing. Again we're back to someone should really look at what's causing the cores and address that issue vs just burying the issue by suppressing the alerts.

21.04 PR: https://github.com/truenas/middleware/pull/6477

21.04 PR: https://github.com/truenas/middleware/pull/6470