Thanks for using the TrueNAS Community Edition issue tracker! TrueNAS Enterprise users receive direct support for their reports from our support portal.

Excessive smartctl usage

Description

smartd needs to be restart on several occasions, including on failover.

Restarting smartd currently takes ~30 secs on a system with 400 disks, which is not acceptable.

It seems we issue smartctl commands for every disk, every single time. That doesnt scale.

We need to decrease the usages of smartctl as much as possible and only call them when necessary.

A suggested improvement would be to call it once when we boot or a disk is plugged in and cache whatever is needed.

After some investigation from Caleb the _service_changed method could also be rethinked, replacing it with service.started() made it a lot faster.

Another consideration is that for TrueNAS hardware we dont care about odd smartctl args, or putting disks to sleep, so these routines can be completely skipped for our hardware.

We have a M60 with 400+ disks to use for this for a short period of time. I will reach out via Slack for creds.

Problem/Justification

None

Impact

None

Activity

Show:

Bug Clerk August 6, 2021 at 10:03 AM

Ievgen Stepanovych August 6, 2021 at 9:53 AM

Bug Clerk August 5, 2021 at 6:35 PM

Complete

Details

Assignee

Reporter

Time remaining

0m

Components

Priority

Katalon Platform

Created August 5, 2021 at 12:55 PM
Updated July 6, 2022 at 9:02 PM
Resolved August 6, 2021 at 4:23 PM

Flag notifications