Fix ValueError crashes
Description
Problem/Justification
None
Impact
None
Activity
Show:
Bug Clerk April 6, 2022 at 12:39 AM
22.02.1 PR: https://github.com/truenas/scale-build/pull/279
Bug Clerk April 1, 2022 at 7:13 PM
Complete
Pinned fields
Click on the next to a field label to start pinning.
Details
Details
Assignee
CalebReporter
Bug ClerkLabels
Time remaining
0m
Components
Fix versions
Priority
LowKatalon Platform
Linked Test Cases, Katalon Defect Results, Katalon Studio Test Results
Katalon Platform
Linked Test Cases, Katalon Defect Results, Katalon Studio Test Results
Created April 1, 2022 at 7:13 PM
Updated July 6, 2022 at 9:02 PM
Resolved April 6, 2022 at 2:26 PM
PR: https://github.com/truenas/scale-build/pull/266
I'm trying to work on some other tickets and I got a message to set SKIP_SOURCE_REPO_VALIDATION so I did export SKIP_SOURCE_REPO_VALIDATION=y
Tried to do make packages and it crashed with ValueError because we're trying to cast the result to int
With these changes, I've added a get_env_variable function that properly sets the environment variables in a programmatic way that should, hopefully, prevent these types of crashes in the future.