Update SCST to check the client-supplied initiator name is a legal value
Description
Problem/Justification
None
Impact
None
relates to
Activity
Show:
Bug Clerk May 16, 2023 at 7:07 PM
Bug Clerk May 16, 2023 at 7:07 PM
22.12.3 PR: https://github.com/truenas/middleware/pull/11315
Automation for Jira May 16, 2023 at 7:07 PM
This issue has now been closed. Comments made after this point may not be viewed by the TrueNAS Teams. Please open a new issue if you have found a problem or need to re-engage with the TrueNAS Engineering Teams.
Bug Clerk May 16, 2023 at 5:55 PM
Brian Meagher May 16, 2023 at 5:48 PM
PR merged into stable/bluefin
Complete
Pinned fields
Click on the next to a field label to start pinning.
Details
Details
Assignee
Brian MeagherReporter
Brian MeagherImpact
Medium
Components
Fix versions
Affects versions
Priority
LowMore fields
Time tracking
More fields
Time trackingKatalon Platform
Linked Test Cases, Katalon Defect Results, Katalon Studio Test Results
Katalon Platform
Linked Test Cases, Katalon Defect Results, Katalon Studio Test Results
Created April 28, 2023 at 3:11 PM
Updated February 27, 2025 at 9:25 PM
Resolved May 16, 2023 at 8:04 PM
Starting in bookworm
SCSTstarted exhibiting poor behavior during unit test runs.The TrueNAS system would reboot during
test_261_iscsi_cmd.py::test_05_chapTurns out the test framework was presenting an illegal initiator name and
SCSTwas rebooting the server (without stack trace) as a result. The identical SCST code behaved in a more resilient manner prior to bookworm.The initiator name supplied (by python-scsi) looked like, e.g.
Removing the
%scaused the reboot to go away, but subsequent tests also had issues with the//when using the initiator name to construct directories under /sys.There are several characters that could cause problems within SCST ('%', ‘/', '#’, etc) and all of them are illegal in iSCSI names. We can avoid a whole class of possible issues by rejecting invalid input.