SmbStatus: Implement ByteRange table and unit tests
Description
Problem/Justification
None
Impact
None
created by
Activity
Show:
Automation for Jira December 4, 2023 at 12:11 PM
This issue has now been closed. Comments made after this point may not be viewed by the TrueNAS Teams. Please open a new issue if you have found a problem or need to re-engage with the TrueNAS Engineering Teams.
Ievgen Stepanovych December 4, 2023 at 12:11 PM
Let's not add new code to support if we don't really have to. Doesn't sound like this is something that's going to be used.
Denys Butenko December 4, 2023 at 11:52 AM
@Ievgen Stepanovych we can ignore or implement this table. what do you think?
pros
have it in place for rare users
ticket is done
cons
perhaps users will not find this page useful
two hours for implementation
Denys Butenko December 1, 2023 at 3:11 PM
Andrew says we can ignore byterange and notifications. However, notifications are already merged, so let's keep them.
Ievgen Stepanovych November 21, 2023 at 12:01 PM
I’m not sure what ByteRange is. Is this something end user may care about?
Not to be Fixed
Pinned fields
Click on the next to a field label to start pinning.
Created November 1, 2023 at 10:49 AM
Updated December 4, 2023 at 12:11 PM
Resolved December 4, 2023 at 12:11 PM
See the parent ticket for data examples
Implement a table for ByteRange from SmbStatus using ix-table2.
Add unit tests
Documentation https://www.samba.org/samba/docs/current/man-html/smbstatus.1.html
With byte-range locks (-B, --byterange):
"byte_range_locks": { "/home/johndoe/testfolder/sample": { "fileid": { "devid": 59, "inode": 11404245, "extid": 0 }, "file_name": "sample", "share_path": "/home/johndoe/testfolder", "locks": [ { "server_id": { "pid": "69650", "task_id": "0", "vnn": "4294967295", "unique_id": "10756714984493602300" }, "type": "R", "flavour": "Posix", "start": 0, "size": 16 } ] }