Add UPS graphs in reporting section in UI
Description
Problem/Justification
Impact
Attachments
- 17 Jan 2024, 02:31 PM
relates to
Activity

Bug Clerk January 18, 2024 at 9:55 AM
This issue has now been closed. Comments made after this point may not be viewed by the TrueNAS Teams. Please open a new issue if you have found a problem or need to re-engage with the TrueNAS Engineering Teams.

Bug Clerk January 17, 2024 at 2:59 PM

Denys Butenko January 17, 2024 at 2:31 PMEdited
request to reporting.netdata_graphs
on qe-minixlplus-01.dc1.ixsystems.net system returns with UPS-related graphs
upscharge
upsruntime
upsvoltage
upscurrent
upsfrequency
upsload
upstemperature
request to reporting.netdata_get_data
with the above-listed params has a response, but data is always an empty array. e.g.
on screenshot look at data: []
It seems does not work as intended.
@Muhammad Rehan could you check and confirm if it is okay?

Denys Butenko December 19, 2023 at 2:25 PM
@Muhammad Rehan
Should we remove it from
reporting.graphs
output if the UPS is not there?
No, I wonder if is there a way to check UPS in system info or ups.*
API endpoints? Because we rely on indirect data to decide when to show the UPS menu item or not.
I think we should show it so if user removes it or disconnects it..we still have historical data being shown, i guess we should be checking if there is any temperature collected or not and UI can show that in the graph that No available data poitns collected
It makes sense. With this approach, my question is irrelevant.

Muhammad Rehan December 19, 2023 at 1:54 PMEdited
@Denys Butenko in bluefin we had removed UPS reporting from middleware which probably explains it being non-existent in graphs response..
How do you think we should have this handled?
Should we remove it from reporting.graphs
output if the UPS is not there? I think we should show it so if user removes it or disconnects it..we still have historical data being shown, i guess we should be checking if there is any temperature collected or not and UI can show that in the graph that No available data poitns collected?
Details
Details
Assignee

Reporter

Middleware has added new UPS graphs and UI should show them appropriately. UI can use
reporting.graphs
endpoint to see which new graphs have been added for UPS service..(please see related ticket for a machine which has a UPS connected to it)