fix HA logic bug
Description
Problem/Justification
Impact
Activity
Bug Clerk October 31, 2024 at 12:55 PM
This issue has now been closed. Comments made after this point may not be viewed by the TrueNAS Teams. Please open a new issue if you have found a problem or need to re-engage with the TrueNAS Engineering Teams.
Bug Clerk October 31, 2024 at 12:54 PM
24.04.2.4 PR: https://github.com/truenas/middleware/pull/14832
Bug Clerk October 31, 2024 at 12:20 PM
This issue has now been closed. Comments made after this point may not be viewed by the TrueNAS Teams. Please open a new issue if you have found a problem or need to re-engage with the TrueNAS Engineering Teams.
Bug Clerk October 31, 2024 at 12:19 PM
24.10.0.1 PR: https://github.com/truenas/middleware/pull/14829
Bug Clerk October 31, 2024 at 9:17 AM
This issue has now been closed. Comments made after this point may not be viewed by the TrueNAS Teams. Please open a new issue if you have found a problem or need to re-engage with the TrueNAS Engineering Teams.
Details
Details
Assignee
Reporter
Labels
Original estimate
Time remaining
Components
Priority
BlockerKatalon Platform
Linked Test Cases, Katalon Defect Results, Katalon Studio Test Results
Katalon Platform
25.04 PR: https://github.com/truenas/middleware/pull/14820
This fixes a bug in our HA logic whereby we're mistakenly ignoring interfaces that are marked critical for failover (treating them as non-critical for failover).
The explanation is simple and I'm surprised we're only now seeing this issue. I check to see if the left operand is `in` the right operand. This means left operand strings with a value of `ens4` will evaluate to true if the right side of the operand is of string `ens4d1`.
The solution is to make sure the left and right operands are equivalent.