Incus instance parser breaks on some values for device sizes

Description

Developer Description of problem
The fix for which was an enhancement request to present the root disk size in API responses for the webui has caused a regression that can break virt.instance.query results because the initial fix does not account for possibility that root device size may be strings such as 32GiB or 32768MiB (in addition to straight count of bytes).

Although we don’t explicitly set these sorts of values through our API, they are supported by backend and failure to properly parse causes widespread UI / API breakage.


Original Ticket Description:
1. No idea
2. No idea
3. No idea

sorry for the crap bug post love the video blog, keep it up!

Session ID: 0dc38bf8-e463-fd64-8f3b-79042aaf5a2e

Problem/Justification

None

Impact

None

Activity

Show:

Mark J 5 hours ago

Oof - missed that I guess. Too much of a casual relationship with the shell I guess.

If I reformat the TrueNAS OS, and import the configuration, will this problem persist?

Andrew Walker 6 hours ago
Edited

Well, you can edit your root disk size via incus commands and change it to “34359738368” instead of 32GiB.

 

before the documentation was written about not going outside of the UI - but I could be wrong.

The MoTD when you have shell access to TrueNAS is:

This has been the case for several years.

You can try doing roughly what I described above, but that aspect (fixing your system) is outside of scope for this bug ticket. You can ask for help on the community forums if you have problems figuring out how to repair the incus config.

Mark J 8 hours ago

Yes, I believe I made the changes in CLI, before the documentation was written about not going outside of the UI - but I could be wrong.

Is there anything I can do besides backing up the configuration and reformatting the boot disk?

Andrew Walker 16 hours ago

Did you perhaps manually edit your incus instances or run scripts against them outside of our UI?

Mark J 19 hours ago

Reboot doesn’t fix the issue. SMB shares and docker apps appear to be working fine(have ability to update, still running web UIs, etc)

Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Impact

Critical

Department

Middleware

Components

Priority

More fields

Katalon Platform

Created 19 hours ago
Updated 4 hours ago